Rule Definition
Not returning value from a getter function can result in data corruption and incorrect behavior
Remediation
Ensure to return a value
Violation Code Sample
new Vue({
el: '#app',
template: '<div>{{ prevYear}} {{ nextYear }}</div>',
data: {
currentYear: new Date().getFullYear()
},
computed: {
prevYear() {
this.currentYear - 1;
},
nextYear: {
get() { // VIOLATION
this.currentYear + 1;
},
set(nextYear) {
this.currentYear = nextYear - 1;
}
}
}
});
Fixed Code Sample
new Vue({
el: '#app',
template: '<div>{{ prevYear}} {{ nextYear }}</div>',
data: {
currentYear: new Date().getFullYear()
},
computed: {
prevYear() {
return this.currentYear - 1;
},
nextYear: {
get() {
return this.currentYear + 1;
},
set(nextYear) {
this.currentYear = nextYear - 1;
}
}
}
});
Reference
https://vuejs.org/v2/guide/computed.html#Computed-Properties
Related Technologies
Technical Criterion
PCI-Requirement-6.5.5 - Improper error handling
About CAST Appmarq
CAST Appmarq is by far the biggest repository of data about real IT systems. It's built on thousands of analyzed applications, made of 35 different technologies, by over 300 business organizations across major verticals. It provides IT Leaders with factual key analytics to let them know if their applications are on track.