CRITICAL
Rule Definition
The software constructs all or part of an command via user-controllable inputs. These inputs are not neutralized or are incorrectly neutralized. As a consequence, the OS command may be completely altered.
Remediation
Use escapeshellcmd or escapeshellarg to escape user input.
Violation Code Sample
$result = mysql_query($conn, $sql);
$row = mysql_fetch_assoc($result);
$host = $row["host"];
passthru("ping -c 1 ".escapeshellarg($host));
Fixed Code Sample
$result = mysql_query($conn, $sql);
$row = mysql_fetch_assoc($result);
$host = $row["host"];
passthru("ping -c 1 ".$host);
Reference
CWE-78: Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection')
https://cwe.mitre.org/data/definitions/78.html
Open Web Application Security Project (OWASP)
https://www.owasp.org/index.php/Top_10-2017_A1-Injection
OWASP Top Ten 2021 Category A03:2021 - Injection
https://owasp.org/Top10/A03_2021-Injection/
Related Technologies
Technical Criterion
CWE-88 - Improper Neutralization of Argument Delimiters in a Command ('Argument Injection')
About CAST Appmarq
CAST Appmarq is by far the biggest repository of data about real IT systems. It's built on thousands of analyzed applications, made of 35 different technologies, by over 300 business organizations across major verticals. It provides IT Leaders with factual key analytics to let them know if their applications are on track.