Rule Definition
The software constructs all or part of a thread parameter using externally-influenced input from an upstream component, but it does not neutralize or incorrectly neutralizes special elements that could modify the intended thread behavior. This could allow attackers to execute unexpected, dangerous commands directly on the operating system. This weakness can lead to a vulnerability in environments in which the attacker does not have direct access to the operating system, such as in web applications.

Remediation
Assume all input is malicious. Avoid using inputs. If it is not possible, use an "accept known good" input validation strategy, i.e., use stringent white-lists that limit the character set based on the expected value of the parameter in the request. This will indirectly limit the scope of an attack.

Violation Code Sample

public void Wait(String apiRequestInput)
{
    int length = int.Parse(apiRequestInput);
    System.Threading.Thread.Sleep(length);
}

Fixed Code Sample

public void Wait(int length)
{
    System.Threading.Thread.Sleep(length);
}

CWE-78: Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection') https://cwe.mitre.org/data/definitions/78.html CWE-383: J2EE Bad Practices: Direct Use of Threads https://cwe.mitre.org/data/definitions/383.html Open Web Application Security Project (OWASP) https://www.owasp.org/index.php/Top_10-2017_A1-Injection CISQ: ASCSM-CWE-078